WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Append 'nohpet' in dom0 cmdline to prevent dom0

To: "Wei, Gang" <gang.wei@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Append 'nohpet' in dom0 cmdline to prevent dom0 from using HPET
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Wed, 14 Oct 2009 12:58:02 -0700
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 14 Oct 2009 13:00:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <8FED46E8A9CA574792FC7AACAC38FE7714FCC2ED95@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <8FED46E8A9CA574792FC7AACAC38FE7714FCC2ED95@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4
On 10/14/09 02:26, Wei, Gang wrote:
> Append 'nohpet' in dom0 cmdline to prevent dom0 from using HPET
>
> Xen is using HPET to wakeup cpu from deep c-states, so the HPET usage in dom0
> must be fobidden. In 2.6.18-xen, the HPET was by default disabled in config
> file. For upstream kernel built for pv dom0, it is not practical to disable 
> dom0
> HPET usage in that way because the same image may be also using as bare metal 
> kernerl. So add cmdline option to do this thing for dom0.
>   

I think it would be better to unstatic disable_hpet() and call it from
Xen setup.  But as far as I can see hpet_init() should never be called
under Xen, because pv_time_ops won't be pointing to it, so there won't
be any attempt to use the hpet.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel