WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xm: Fix xm network2-{attach,detach}

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xm: Fix xm network2-{attach,detach}
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Wed, 14 Oct 2009 15:02:32 +0900
Delivery-date: Tue, 13 Oct 2009 23:03:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
xm help doesn't work. Fixes in passing.
- A comma is missing.
- less help message.
- typo.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r 5d779377a9ae tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Mon Oct 12 12:56:00 2009 +0100
+++ b/tools/python/xen/xm/main.py       Wed Oct 14 14:44:08 2009 +0900
@@ -184,7 +184,8 @@ SUBCOMMAND_HELP = {
     'network2-attach': ('<Domain> [front_mac=<mac>] [back_mac=<mac>] '
                         '[backend=<BackDomain>] [trusted=<0|1>] '
                         '[back_trusted=<0|1>] [bridge=<bridge>] '
-                        '[max_bypasses=n]'
+                        '[filter_mac=<0|1>] [front_filter_mac=<0|1>] '
+                        '[pdev=<PDEV>] [max_bypasses=n]',
                         'Create a new version 2 virtual network device.'),
     'network2-detach': ('<Domain> <DevId> [-f|--force]',
                          'Destroy a domain\'s version 2 virtual network 
device.'),
@@ -2450,7 +2451,7 @@ def xm_block_configure(args):
 
 def xm_network2_attach(args):
     xenapi_unsupported()
-    arg_check(args, 'network2-attach', 1, 4)
+    arg_check(args, 'network2-attach', 1, 11)
     dom = args[0]
     vif = ['vif2']
     vif_params = ['front_mac', 'back_mac', 'backend', 'trusted',
@@ -2467,7 +2468,7 @@ def xm_network2_attach(args):
 
 def xm_network2_detach(args):
     xenapi_unsupported()
-    arg_check(args, "network2-detch", 2, 3)
+    arg_check(args, "network2-detach", 2, 3)
     detach(args, "vif2")
 
 def xm_network2_list(args):
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xm: Fix xm network2-{attach,detach}, Kouya Shimura <=