WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 7] pcilib: define endianness for minios

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 7] pcilib: define endianness for minios
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 12 Oct 2009 18:35:06 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 12 Oct 2009 10:35:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091012173121.GA5961@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.0910121754020.4616@kaball-desktop> <20091012173121.GA5961@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Mon, 12 Oct 2009, Samuel Thibault wrote:
> Stefano Stabellini, le Mon 12 Oct 2009 18:19:57 +0100, a écrit :
> > Include endian.h for MiniOS.
> 
> Err, could you reorder the hooks the same way as in the existing pcilib
> patch?  As it is now, your patch is unreadable just because of this :)
> 

I know it is unreadable, this is the actual difference between the two
trees:


diff -uNpbE -r pciutils-x86_32/lib/sysdep.h 
/dev/xensource/xen-unstable-stubdompass/stubdom/pciutils-x86_32/lib/sysdep.h
--- pciutils-x86_32/lib/sysdep.h        2007-02-06 12:00:18.000000000 +0000
+++ 
/dev/xensource/xen-unstable-stubdompass/stubdom/pciutils-x86_32/lib/sysdep.h    
    2009-10-09 19:01:51.000000000 +0100
@@ -32,6 +32,10 @@ typedef u16 word;
 
 #else
 
+#ifdef PCI_OS_MINIOS
+#include <machine/endian.h>
+#endif
+
 #ifdef PCI_OS_LINUX
 #include <endian.h>
 #define BYTE_ORDER __BYTE_ORDER
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel