[Xen-devel] Re: [PATCH 3/3] Fix compilation issues with CONFIG_D

On 10/08/09 10:23, Konrad Rzeszutek Wilk wrote:
> The recent fix for GART on Xen included an extra include which
> caused the build to choke when building the ttm drivers.
>   

How does the compile fail?  (Generally its best to include the
compilation error messages when submitting a compile-fix patch.)

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/agp.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/agp.h b/arch/x86/include/asm/agp.h
> index 8107b71..3282ea6 100644
> --- a/arch/x86/include/asm/agp.h
> +++ b/arch/x86/include/asm/agp.h
> @@ -3,7 +3,6 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/cacheflush.h>
> -#include <asm/dma-mapping.h>
>   

The code below uses dma_alloc/free_coherent, so it needs some header for
the prototypes.  Perhaps it should be linux/dma-mapping.h?

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] paravirt-dom0: ACPI_PROCESSOR_XEN (bool) depends on ACPI_PROCESSOR (tristate), Jeremy Fitzhardinge

Next by Date:

[Xen-devel] Re: [PATCH 3/3] Fix compilation issues with CONFIG_DRM_TTM enabled., Konrad Rzeszutek Wilk

Previous by Thread:

[Xen-devel] [PATCH 3/3] Fix compilation issues with CONFIG_DRM_TTM enabled., Konrad Rzeszutek Wilk

Next by Thread:

[Xen-devel] Re: [PATCH 3/3] Fix compilation issues with CONFIG_DRM_TTM enabled., Konrad Rzeszutek Wilk

Indexes:

[Date] [Thread] [Top] [All Lists]