WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] support of lock profiling in Xen

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] support of lock profiling in Xen
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 08 Oct 2009 10:47:25 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 08 Oct 2009 02:47:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4ACDB273.1090909@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpH+rjUUvexUz5oQeGvpxoEDEN2hQAAZ4k/
Thread-topic: [Xen-devel] [Patch] support of lock profiling in Xen
User-agent: Microsoft-Entourage/12.20.0.090605
On 08/10/2009 10:35, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

>> After all, now I think about it, an 'arbitrary' index specified to
>> spinlock_init() is just making our lives more complicated if it will
>> basically *always* be a domid. And knowing at a higher level which locks are
>> actually per-domain could help your pretty printing?
> 
> I thought in this direction, too.
> I would, however, try not to limit it to per domain locks, even if the first
> implementation would support only global locks and per domain locks.
> 
> The perfc style declarations should only be necessary for the dynamically
> initialized locks, and those could live near the domain structure definition
> (or any other structure where they are needed).
> 
> I think the statically defined locks can be handled via an own data section
> requiring no centrally defined index.

Okay, well this all sounds an acceptable kind of direction. Worth spinning
another patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel