Re: [Xen-devel] [Patch] support of lock profiling in Xen

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 08/10/2009 10:35, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

>> After all, now I think about it, an 'arbitrary' index specified to
>> spinlock_init() is just making our lives more complicated if it will
>> basically *always* be a domid. And knowing at a higher level which locks are
>> actually per-domain could help your pretty printing?
> 
> I thought in this direction, too.
> I would, however, try not to limit it to per domain locks, even if the first
> implementation would support only global locks and per domain locks.
> 
> The perfc style declarations should only be necessary for the dynamically
> initialized locks, and those could live near the domain structure definition
> (or any other structure where they are needed).
> 
> I think the statically defined locks can be handled via an own data section
> requiring no centrally defined index.

Okay, well this all sounds an acceptable kind of direction. Worth spinning
another patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel