WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC] Correct/fast timestamping in apps under Xen [1 of

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC] Correct/fast timestamping in apps under Xen [1 of 4]: Reliable TSC
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 08 Oct 2009 07:54:46 +0100
Cc: "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Delivery-date: Wed, 07 Oct 2009 23:55:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6F34901.16D4A%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpHknUpvBDM9ZIzR4+2OHs4ahwBiQAUGkRYAABWk3I=
Thread-topic: [Xen-devel] [RFC] Correct/fast timestamping in apps under Xen [1 of 4]: Reliable TSC
User-agent: Microsoft-Entourage/12.20.0.090605
On 08/10/2009 07:45, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> 1) On (Intel, maybe later AMD) systems where this
>>    bit is set, the mechanisms enabled by the
>>    Xen consistent_tscs boot option should be enabled
>>    automatically for Xen.
>> 2) The time_calibration_tsc_rendezvous loop in
>>    timer.c could/should be rewritten or removed
>>    and certainly should NOT write_tsc().
>> 
>> Keir, I know you are very sensitive around
>> this code, so thought I'd check before messing
>> with it.  Or feel free to do it yourself.
> 
> Feel free to make a patch.

At least, make a patch for (1). I don't think (2) can be easily removed in
all cases. For example, Intel's method for rate-invariant TSC which stops on
deep sleeps does involve rewriting TSC values to forcibly keep them in sync.
Perhaps change code to never write_tsc() just in the case of TSC_RELIABLE,
or whatever you call it? Or perhaps just do (1) for now.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>