WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix hypervisor crash with unpopulated NUMA nodes

To: "Andre Przywara" <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix hypervisor crash with unpopulated NUMA nodes
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 07 Oct 2009 12:53:55 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 07 Oct 2009 04:54:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4ACC6346.5080309@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4ACC6346.5080309@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Andre Przywara <andre.przywara@xxxxxxx> 07.10.09 11:45 >>>
>on NUMA systems with memory-less nodes Xen crashes quite early in the 
>hypervisor (while initializing the heaps). This is not an issue if this 
>happens to be the last node, but "inner" nodes trigger this reliably.
>On multi-node processors it is much more likely to leave a node unequipped.
>The attached patch fixes this by enumerating the node via the 
>node_online_map instead of counting from 0 to num_nodes.

While I do not see anything wrong with the patch, I still wonder why it
would be needed: It seems to indicate that node_online_map represents
only nodes with memory, but imo should be representing nodes with
memory or processors (leaving aside pure I/O nodes for the moment).
So perhaps there's rather a problem with the setup of node_online_map 
somewhere?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>