| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 07 of 10] Transitive grant support
On 05/10/2009 09:02, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>> - unsigned long frame; /* Frame being granted. */
>> + domid_t trans_dom;
>> + uint32_t trans_gref;
>> + uint32_t frame; /* Frame being granted. */
>
> Using a uint32_t for a frame number is not valid anymore after the recent
> sparse physical memory support changes (and I don't think it would have
> been valid on ia64 even before).
What about the 'uint32_t frame' in grant_entry_v2_t -- I'm surprised you
didn't mention that also? It's most critical we get the sizing of that
correct, while we're rev'ing a public interface. Given the definition of
__spacer[], it looks like there's space to have a full 'uint64_t frame' in
that structure too, no problem. A bit of field reordering might be needed to
make everything align naturally yet compactly, is all, I think?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home