WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH] VNIF: Using smart polling instead of event notifi

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] VNIF: Using smart polling instead of event notification.
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 02 Oct 2009 12:10:00 -0700
Cc: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 02 Oct 2009 12:10:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1254476489.12198.27.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501CEB99EAF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1254476489.12198.27.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3
On 10/02/09 02:41, Ian Campbell wrote:
> On Thu, 2009-10-01 at 15:02 +0100, Xu, Dongxiao wrote:
>   
>> We found that the event notification frequency is still high in some network 
>> cases. NAPI polls only for a little
>> time slot and does not efficient enough in our backend/frontend case. 
>> Actually our patch repeated calling NAPI
>> interface to do more polling, and netback will NOT notify netfront during 
>> this period. Once netfront polling out
>> all the data, and finds that there is no more data arrive/send during the 
>> next 100ms, the timer will stop working 
>> to end the polling. 
>>     
> Isn't that an argument for improving NAPI rather than coding workarounds
> into each driver? As physical NICs increase in speed it seems like NAPI
> will need to increase its efficiency in a similar manner.
>
> It would be interesting to run the patches past netdev@vger.
>   

Yes.  NAPI is intended to address precisely this issue, so it should be
made to work.

>>     This filed 'smart_poll_active' is shared by netfront and netback,
>> to indicate whether netfront is polling data. 
>> So this filed is necessary for netback to notify netfront if this flag
>> is not set. 
>>     
> Right, but that doesn't justify sticking a netfront specific field in a
> generic ring structure.
>   

This kind of poll/interrupt switch isn't network-specific though; this
just happens to be the first user.   Presumably other devices with a
high rate of small messages could also take advantage of it.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel