 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks bug of c/s 20218
| To: | Kouya Shimura <kouya@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks bug of c/s 20218 |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 18 Sep 2009 08:51:49 +0100 |
| Cc: | Christoph Egger <Christoph.Egger@xxxxxxx> |
| Delivery-date: | Fri, 18 Sep 2009 00:52:35 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <7k8wgcdduj.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Aco4IFMkm8PkNWncQ6adS5BZakBDKQAFI1li |
| Thread-topic: | [PATCH] x86 hvm: fix missing ticks bug of c/s 20218 |
| User-agent: | Microsoft-Entourage/12.20.0.090605 |
Moving the line 'pt->scheduled += pt->period' inside the if statement looks pretty dubious. Does your fix still work if we don't move that line? For the default timer mode I'm not sure it should make any difference either way, but it would for timer mode 0. -- Keir On 18/09/2009 06:24, "Kouya Shimura" <kouya@xxxxxxxxxxxxxx> wrote: > With c/s 20218, timer ticks might be missed when IRQs of a timer are queued. > Next scheduled time is accumulated wrongly. > > Thanks to Christoph for the report. > > Thanks, > Kouya > > Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx> > Reported-by: Christoph Egger <Christoph.Egger@xxxxxxx> > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [PATCH] EPT: Only sync pcpus on which a domain's vcpus might be running, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] Re: pvclock in userland (reprise), Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] x86 hvm: fix missing ticks bug of c/s 20218, Kouya Shimura |
| Next by Thread: | [Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks bug of c/s 20218, Kouya Shimura |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
