WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] RE: [PATCH] Don't free irqaction for com irq when releas

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [PATCH] Don't free irqaction for com irq when release irq.
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Thu, 3 Sep 2009 20:53:56 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 03 Sep 2009 05:54:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200909031204.53521.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <706158FABBBA044BAD4FE898A02E4BC201C43C4D4E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C6C51D46.13BFA%keir.fraser@xxxxxxxxxxxxx> <706158FABBBA044BAD4FE898A02E4BC201C43C4F67@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200909031204.53521.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcosfgUvIHXgmF7HQN6CVffYrcFiuAADAueg
Thread-topic: [Xen-devel] RE: [PATCH] Don't free irqaction for com irq when release irq.
I think Jan also answered your question.   Dom0 shouldn't touch ioapic after 
initialization time any more.  That is to say, maybe we can find a way to get 
rid of ioapic from dom0.  Actually I can't see why dom0 cares so much about 
ioapic.   Jeremy, do you know the reason ?  IMO, dom0 should only cares about 
GSI and pirq mapping, but currently GSI is always equal to pirq in dom0, so no 
reason to keep ioapic in dom0. 
Xiantao

-----Original Message-----
From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx] 
Sent: Thursday, September 03, 2009 6:05 PM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: Zhang, Xiantao; Keir Fraser
Subject: Re: [Xen-devel] RE: [PATCH] Don't free irqaction for com irq when 
release irq.

On Thursday 03 September 2009 11:38:35 Zhang, Xiantao wrote:
> No, host S3 issue is caused by ioapic suspend/resume in dom0.  IMO, dom0
> shouldn't perform S3 for ioapic , right ?

dom0 initializes and programs ioapic. In short: ioapic is under control of 
dom0. Please explain why dom0 shouldn't do ioapic suspend/resume.

Christoph

> After fixing that issue, domain 
> S3 works well. Xiantao
>
> -----Original Message-----
> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> Sent: Thursday, September 03, 2009 2:14 PM
> To: Zhang, Xiantao; Xen
> Subject: Re: [PATCH] Don't free irqaction for com irq when release irq.
>
> On 03/09/2009 05:14, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> wrote:
> > # HG changeset patch
> > # User root@xxxxxxxxxxxxxxxxxxxxx
> > # Date 1251916103 14400
> > # Node ID 49e847aed58dde35f8a0f909999d01d97be6f531
> > # Parent  3b7cbf32fee909d860daacf70b8c3b97eaf036b5
> > x86: com devices's irqaction shouldn't free.
> >
> > Since irqs of serial devices are initialized in early Xen and
> > its irqaction is not allocated from heap, so doesn't need free
> > in release irq logic.
> > Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
>
> Does this fix host S3?
>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel