WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: a room for blkio-cgroup in struct page_cgroup

To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: a room for blkio-cgroup in struct page_cgroup
From: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
Date: Thu, 3 Sep 2009 01:32:24 +0530
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, containers@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, Ryo Tsuruta <ryov@xxxxxxxxxxxxx>
Delivery-date: Wed, 02 Sep 2009 13:02:46 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=QKlGaEuo5DQVLnlyCAc4+o5cvbB+ZQRE3g43AudWVr0=; b=GxDQgszPIRKXBZHQWBlCeGhouawpp9JXQcxbfAVw+6GWgBuRWNiip1OlWtEpes+ekG sA9arciJabJXplSuf2xzzfPXpopleQEjLlPFIV+7qaXdiL8j3Um+MRJsmlLdVqZdHLEc 2kzaqBnhw1D9meFEqGDZRhbssmQqith8k4jGY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=sbA1RpLag1avaxypU6elvbjgQXiZKmAN4AGZUMrzw04wqYIp1PW76afpQEVsHGw335 /GOpssUV+LHtGvvNrTzMjLJi/Odr5Qp0384bg5uXQKfyPcc+YnDVoxFI54gFoJOOB+hM DFSlqMnjbcX4pPDd56GEP5GBKWABRtisCkdJI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ff13736137802f78cf492d13c43c1af1.squirrel@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090902.205137.71100180.ryov@xxxxxxxxxxxxx> <ff13736137802f78cf492d13c43c1af1.squirrel@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
2009/9/2 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>:
> Ryo Tsuruta wrote:
>> Hi Kamezawa-san,
>>
>> As you wrote before (http://lkml.org/lkml/2009/7/22/65)
>>> To be honest, what I expected in these days for people of blockio
>>> cgroup is like following for getting room for themselves.
>> <<snip>>
>>> --- mmotm-2.6.31-Jul16.orig/include/linux/page_cgroup.h
>>> +++ mmotm-2.6.31-Jul16/include/linux/page_cgroup.h
>>> @@ -13,7 +13,7 @@
>>>  struct page_cgroup {
>>>       unsigned long flags;
>>>       struct mem_cgroup *mem_cgroup;
>>> -     struct page *page;
>>> +     /* block io tracking will use extra unsigned long bytes */
>>>       struct list_head lru;       /* per cgroup LRU list */
>>> };
>>
>> Have you already added a room for blkio_cgroup in struct page_cgroup?
> No.
>

The diff above is unclear, are you removing struct page from page_cgroup?

Balbir Singh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel