This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] [IOEMU]: fix the crash of HVM live migration wit

To: Gianluca.Guida@xxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] [IOEMU]: fix the crash of HVM live migration with intensive disk access
From: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Date: Tue, 01 Sep 2009 08:40:23 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 31 Aug 2009 17:41:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A823278.6050207@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090811121251.GA16082@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0908111347410.28872@kaball-desktop> <4A823278.6050207@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080914)

Do you have comments for this? Maybe Stefano and I are on the same page. My assumption is that we need keep the cpu_physical_memory_set_dirty and phys_ram_dirty for qemu itself, and make cpu_physical_memory_set_dirty call xc_hvm_modified_memory if in live migration.


Zhai, Edwin wrote:

Stefano Stabellini wrote:
On Tue, 11 Aug 2009, Zhai, Edwin wrote:
[IOEMU]: fix the crash of HVM live migration with intensive disk access

Intensive disk access, e.g. sum of big file, during HVM live migration would cause guest error even file system crash. Guest dmesg said
"attempt to access beyond end of device
hda1: rw=0, want=10232032112, limit=10474317"

Current map cache used by qemu dma doesn't mark the page dirty, so that these pages(probably holding DMA data struct) are not transferred in the last iteration during live migration.

This patch fixes it, and also merges the qemu's original dirty bitmap used by other devices such as vga.

Signed-Off-By: Zhai Edwin <edwin.zhai@xxxxxxxxx>

I think the fix is correct but we should thinking about dropping
logdirty and start using xc_hvm_modified_memory instead for all cases.

One interface should be better. But I'm not sure about the perf implications. You know, qemu use logdirty for its device emulation even without live migration, e.g. vga screen refresh. Changing to xc_hvm_modified_memory would cause many hypercall to set/get the bitmap in xen...

I think Gianluca also may have something to say about this but this week
he is on vacation.

best rgds,

Xen-devel mailing list