This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH][PV_OPS_DOM0] Fix domain0 hang when cpuidle is di

To: "Yu, Ke" <ke.yu@xxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][PV_OPS_DOM0] Fix domain0 hang when cpuidle is disabled in Xen
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Mon, 31 Aug 2009 11:30:54 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 30 Aug 2009 20:32:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D05DB80B95B23498C72C700BD6C2E0B339DC0B0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D05DB80B95B23498C72C700BD6C2E0B339DC0B0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcopGN3RFZhC0WWJSciPYMfo6jfMuwA0TQoA
Thread-topic: [Xen-devel] [PATCH][PV_OPS_DOM0] Fix domain0 hang when cpuidle is disabled in Xen
   We had verified this patch on our Core i7 platforms, and it should make dom0 
hang issue disappear.  As Ke described, dom0 shouldn't enter into real C states 
in any case, othwerwise it may lead to Xen hypervisor's issues (e.g. timer 
issue, scheduler issues and so on.) and result in dom0 hang during boot 
eventually.  Would you apply this patch to make rebase/master branch work 
again?  Thanks! :-) 

Acked-by : Xiantao Zhang <xiantao.zhang@xxxxxxxxx> 

Yu, Ke wrote:
>     Fix the issue of domain0 hang when cpuidle is disabled in Xen
>     when cpuidle is disabled in xen, domain0 will use native cpuidle
> driver to enter real C state, which is not allowed and will cause
> domain0 hang. this patch change the condition check to fix this
> issue.   
>     Signed-off-by: Yu Ke <ke.yu@xxxxxxxxx>
> diff --git a/drivers/acpi/processor_idle.c
> b/drivers/acpi/processor_idle.c 
> index c2e24ac..a7308bb 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1146,7 +1146,7 @@ int acpi_processor_cst_has_changed(struct
>       acpi_processor *pr) if (!pr->flags.power_setup_done)
>               return -ENODEV;
> -    if (processor_cntl_xen_pm()) {
> +    if (xen_initial_domain()) {
>               acpi_processor_get_power_info(pr);
>               processor_cntl_xen_notify(pr,
>                       PROCESSOR_PM_CHANGE, PM_TYPE_IDLE);
> @@ -1216,7 +1216,7 @@ int __cpuinit acpi_processor_power_init(struct
> acpi_processor *pr, 
>        * platforms that only support C1.
>        */
>       if (pr->flags.power) {
> -             if (processor_cntl_xen_pm())
> +             if (xen_initial_domain())
>                       processor_cntl_xen_notify(pr,
>                                       PROCESSOR_PM_INIT, PM_TYPE_IDLE);
>               else {

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>