This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xenfb: connect to backend before registering fb

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenfb: connect to backend before registering fb
From: Markus Armbruster <armbru@xxxxxxxxxx>
Date: Fri, 28 Aug 2009 11:12:42 +0200
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Michal Schmidt <mschmidt@xxxxxxxxxx>
Delivery-date: Fri, 28 Aug 2009 02:13:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A96DD03.2080808@xxxxxxxx> (Jeremy Fitzhardinge's message of "Thu\, 27 Aug 2009 12\:22\:43 -0700")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A96DD03.2080808@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)
Jeremy Fitzhardinge <jeremy@xxxxxxxx> writes:

> As soon as the framebuffer is registered, our methods may be called by the
> kernel. This leads to a crash as xenfb_refresh() gets called before we have
> the irq.
> Connect to the backend before registering our framebuffer with the kernel.
> [ Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14059 ]
> Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

Looks good to me.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>