This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] softtsc for PV domains

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] softtsc for PV domains
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 27 Aug 2009 17:00:54 +0100
Delivery-date: Thu, 27 Aug 2009 09:01:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ead4e61f-6e48-49f6-8173-73de6f8dfdb5@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AconLM4SGyD35hZJSA+xtJljnNSXlwAAsBZd
Thread-topic: [Xen-devel] [PATCH] softtsc for PV domains
User-agent: Microsoft-Entourage/
On 27/08/2009 16:40, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> Changeset 20128 is a fixed and simplified version of this.
>> Please take a
>> look and test.

> Looks good and seems to work.  I'm not sure why you wanted
> to move the frequency info from the "t" debug key to the
> new "s" debug key... and I'm a bit worried that since the "s"
> key only registers if booted with softtsc, someone else will
> use the "s" key for something else and cause a conflict
> that won't be noticed until later.

The arch_ func thing was ugly and also broke ia64.

It'd be better probably to collect stats per-domain and then hook into

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>