This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Fix bzip2/lzma compilation/linking problems in tools

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix bzip2/lzma compilation/linking problems in tools/libxc/Makefile
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Sun, 23 Aug 2009 20:08:31 +0300
Cc: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Sun, 23 Aug 2009 10:08:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)

The attached patch fixes two problems in tools/libxc/Makefile in xen-unstable.

1) libxenguest.so.3.4.0 is linked from *.opic files, so the -DHAVE_BZLIB 
CFLAGS need to be added to xc_dom_bzimageloader.opic aswell.

2) There was an ordering/dependency problem with .zlib.deps file generation 
in missing CFLAGS for xc_dom_bzimageloader.o|.opic compilation.

ie. sometimes (for example during rpmbuild) this is what happened:

grep: .zlib.deps: No such file or directory
 - BZIP2 decompression supported
 - LZMA decompression supported

The .zlib.deps file generation was done _after_ the CFLAGS += stuff was ran..
obviously resulting in missing BZIP2/LZMA support.

I fixed this by making the .zlib.deps generation being the first thing to run.

-- Pasi

Attachment: xen-unstable-fix-makefile-bzip2-lzma-support.patch
Description: Text Data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>