This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] x86: run timers when populating Dom0's P2M table

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: run timers when populating Dom0's P2M table
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 21 Aug 2009 16:52:38 +0100
Delivery-date: Fri, 21 Aug 2009 08:52:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
When booting Dom0 with huge amounts of memory, and/or memory accesses
being sufficiently slow (due to NUMA effects), and the ACPI PM timer or
a high frequency HPET being used, the time it takes to populate the M2P
table may significantly exceed the overflow time of the platform timer,
screwing up time management to the point where Dom0 boot fails.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2009-08-18.orig/xen/arch/x86/domain_build.c 2009-06-19 11:11:23.000000000 
+++ 2009-08-18/xen/arch/x86/domain_build.c      2009-08-21 17:38:51.000000000 
@@ -927,6 +927,8 @@ int __init construct_dom0(
             ((unsigned int *)vphysmap_start)[pfn] = mfn;
         set_gpfn_from_mfn(mfn, pfn);
+        if (!(pfn & 0xfffff))
+            process_pending_timers();
     si->first_p2m_pfn = pfn;
     si->nr_p2m_frames = d->tot_pages - count;
@@ -945,6 +947,8 @@ int __init construct_dom0(
 #ifndef NDEBUG
+            if (!(pfn & 0xfffff))
+                process_pending_timers();
     BUG_ON(pfn != d->tot_pages);
@@ -965,6 +969,8 @@ int __init construct_dom0(
             set_gpfn_from_mfn(mfn, pfn);
 #undef pfn
             page++; pfn++;
+            if (!(pfn & 0xfffff))
+                process_pending_timers();

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86: run timers when populating Dom0's P2M table, Jan Beulich <=