This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Add password support to pygrub for GRUB bootload

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add password support to pygrub for GRUB bootloader
From: Michal Novotny <minovotn@xxxxxxxxxx>
Date: Fri, 21 Aug 2009 12:18:43 +0200
Delivery-date: Fri, 21 Aug 2009 03:19:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A8D658D.1070406@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A8D658D.1070406@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090609)
this patch (applied as http://xenbits.xensource.com/xen-unstable.hg?rev/8f783adc0ee3 , c/s 20099) introduced a problem for Itanium systems using LiloConf. This patch is the fix for elilo. Since I am unable to find information whether eLilo supports password protection or not, this patch makes the entry and command-line editing on IA64 systems as if no patch with c/s 20099 was applied.


Michal Novotny wrote:
this is the patch to add password support to pygrub for GRUB bootloader. It basically checks for the presence of password line in grub.conf of the guest image and if this line is present, it supports both clear text and md5 versions of the password. Editing the grub entries and command-line are disabled when some password is set in domain's grub.conf file but the password was not entered yet. Also, new option to press 'p' in interactive pygrub has been added to allow entering the grub password. It's been tested on x86_64 with PV guests and was working fine. Also, the countdown has been stopped after key was pressed, ie. the user is probably editing the boot configuration.


Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx>

Xen-devel mailing list

diff -r 7dad2e23bf89 tools/pygrub/src/LiloConf.py
--- a/tools/pygrub/src/LiloConf.py      Thu Aug 20 22:26:16 2009 +0100
+++ b/tools/pygrub/src/LiloConf.py      Fri Aug 21 12:15:02 2009 +0200
@@ -138,6 +138,12 @@ class LiloConfigFile(object):
         if len(img) > 0:
             self.add_image(LiloImage(img, path))
+    def hasPassword(self):
+        return False
+    def hasPasswordAccess(self):
+        return True
     def add_image(self, image):
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>