WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: RE: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Wed, 19 Aug 2009 09:25:08 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Kleen, Andi" <andi.kleen@xxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 18 Aug 2009 18:27:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A8AEA3F.6020206@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098402CDF6599F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A7174D3020000780000D350@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CDF65BEB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CDF65C35@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A71D4F8.70804@xxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CE0B5780@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A7A0DF7.5040706@xxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CE0B6567@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A7C6D67.7090202@xxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CE11BCA8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A8A8A290200007800010437@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CED1D9A9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A8AEA3F.6020206@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcogLJntUgncgdSORuKv9y5UnA31gQAPpQwg
Thread-topic: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops
Hi, Jeremy
This is the delta patch. Thanks a lot!

Regards,
Criping


>From 1d3152ae0c69a4618bb2137ec5bf150d595de26f Mon Sep 17 00:00:00 2001
From: root <root@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Aug 2009 09:16:22 +0800
Subject: [PATCH] Small fix for MCA Logging in pv-ops

We need to move mce vIRQ handler registration after all
other ops succeeds as Jan points out.

Signed-off-by: Liping Ke<liping.ke@xxxxxxxxx>
---
 drivers/xen/mce.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/xen/mce.c b/drivers/xen/mce.c
index ef838f2..b354dc8 100644
--- a/drivers/xen/mce.c
+++ b/drivers/xen/mce.c
@@ -148,14 +148,6 @@ static int bind_virq_for_mce(void)
        int ret;
        xen_mc_t mc_op;
 
-       ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
-               mce_dom_interrupt, 0, "mce", NULL);
-
-       if (ret < 0) {
-               printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
-               return ret;
-       }
-
        g_mi = kmalloc(sizeof(struct mc_info), GFP_KERNEL);
 
        if (!g_mi)
@@ -189,6 +181,14 @@ static int bind_virq_for_mce(void)
                return ret;
        }
 
+       ret  = bind_virq_to_irqhandler(VIRQ_MCA, 0,
+               mce_dom_interrupt, 0, "mce", NULL);
+
+       if (ret < 0) {
+               printk(KERN_ERR "MCE_DOM0_LOG: bind_virq for DOM0 failed\n");
+               return ret;
+       }
+
        return 0;
 }
 
-- 
1.5.1





Jeremy Fitzhardinge wrote:
> On 08/18/09 02:25, Ke, Liping wrote:
>> Hi, Jan
>> Yes, the added physinfo fetch op should be placed before
>> registering the vIRQ handler. Thanks for pointing out. Below is the
>> updated patch. 
>> 
> 
> Please send a delta against the previous patch.
> 
>     J

Attachment: 0001-Small-fix-for-MCA-Logging-in-pv-ops.patch
Description: 0001-Small-fix-for-MCA-Logging-in-pv-ops.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel