This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling

To: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Sat, 15 Aug 2009 00:02:30 -0700
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
Delivery-date: Sat, 15 Aug 2009 00:03:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090808201500.GA21828@feather>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090808201500.GA21828@feather>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2
On 08/08/09 13:15, Josh Triplett wrote:
> CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that,
> resulting in this warning:
> arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
> arch/x86/xen/enlighten.c:192: warning: ‘cx’ may be used uninitialized in this 
> function
> arch/x86/xen/enlighten.c:205: note: ‘cx’ was declared here
> Set cx = 0 to avoid this warning.  This seems preferable to implementing
> a xen_cpuid_nocount without the input constraint for cx, and either of
> those seem preferable to just ignoring the warning.

Thanks, applied.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>