WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] RE: [PATCH][ioemu] support the assignment of the VF of I

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [PATCH][ioemu] support the assignment of the VF of Intel 82599 10GbE Controller
From: "Rose, Gregory V" <gregory.v.rose@xxxxxxxxx>
Date: Thu, 6 Aug 2009 08:54:27 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 06 Aug 2009 08:54:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457501CB91EB9F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501CB84D148@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19064.17865.245036.788707@xxxxxxxxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501CB91EB9F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoVD/7GCivrOEvHR9C5VZyaRWYvuQAYSAEgAE81BjA=
Thread-topic: [Xen-devel] RE: [PATCH][ioemu] support the assignment of the VF of Intel 82599 10GbE Controller
Future generations of Intel 10Gig controllers that support SR-IOV will not have 
this problem.  It is a design flaw unique to the 82599.  It's unlikely that 
other manufacturer's controllers would have this same issue.  I'd agree with 
Dexuan that it would be better to wait and see if the table becomes necessary.  
At this time I think it probably won't be.

- Greg 

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Cui, Dexuan
Sent: Tuesday, August 04, 2009 10:17 PM
To: Ian Jackson
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] RE: [PATCH][ioemu] support the assignment of the VF of 
Intel 82599 10GbE Controller

Ian Jackson wrote:
> Cui, Dexuan writes ("[PATCH][ioemu] support the assignment of the VF
> of Intel 82599 10GbE Controller"): 
>> The datasheet is available at
>> http://download.intel.com/design/network/datashts/82599_datasheet.pdf
>> 
>> See 'Table 9.7. VF PCIe Configuration Space' of the datasheet, the
>> PCI Express Capability Structure of the VF of Intel 82599 10GbE
>> Controller looks trivial, e.g., the PCI Express Capabilities
>> Register is 0, so the Capability Version is 0 and
>> pt_pcie_size_init() would fail. 
>> 
>> We should not try to expose the PCIe cap of the device to guest.
> 
> I've applied this for now but it seems a bit ugly to code in the
> device IDs in this way.
Thanks.

>  Couldn't we instead detect this situation
> programmatically ?  Alternatively, if this is going to happen for
> other devices, do we want to provide a proper whitelist in the form of
> a table ?
Using the patch (yes, that's a quirk) I think we can have the least change.
I'm not sure if there are other devices having the same issue.
I think we can wait to see if there are so many such devices that we can make a 
table. :-)

Thanks,
-- Dexuan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel