This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 30 Jul 2009 11:57:32 +0200
Cc: jeremy@xxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>
Delivery-date: Thu, 30 Jul 2009 02:59:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E2263E4A5B2284449EEBD0AAB751098402CDF6599F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098402CDF6599F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
Hi Ke Liping!

The xen mca public header needs some comment updates in the xen tree first
before it populates to the guests:

In line 102, uncorrectable errors are not reported via nmi handlers.
Please update the comment to match the code.

In struct mcinfo_recovery, it is not obvious that the REC_ACTION_* flags are 
intended to be used in action_flags. Please add a comment to make this clear.

In struct mcinfo_recovery, it is not obvious that the MC_ACTION_* flags are
intended to be used in action_types. Actually are these flags?
These are defined as a bitfield, but the union can't store more than one 
action. Please add a comment to clarify this.

For xen_mc_notifydomain, it is not clear if this has to be used before or 
after acknowledging the fetched telemetry. Please update the comment
to clarify this.

In xen_mc_notifydomain, the comment this the flags field may contain 
XEN_MC_TRAP which doesn't exist. Please update the comment.


On Thursday 30 July 2009 07:15:05 Ke, Liping wrote:
> Hi, Jeremy and Keir
> This patch is backport from DOM0 cs902
> When an MCE/CMCI error happens (or by polling), the related error
> information will be sent to DOM0 by XEN. This patch will help to fetch
> the xen-logged information by hypercall and then convert XEN-format
> log into Linux format MCELOG. It makes using current available mcelog
> tools for native Linux possible.
> With this patch, after mce/cmci error log information is sent to DOM0,
> running mcelog tools in DOM0, you will get same detailed decoded mce
> information as in Native Linux.
> Signed-Off-By: Liping Ke <liping.ke@xxxxxxxxx>
> Signed-Off-By: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>
> Thanks& Regards,
> Criping

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list