This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI de

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Tue, 28 Jul 2009 17:04:42 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jul 2009 02:07:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090728085646.GA31294@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200905300930.n4U9UOTG008828@xxxxxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501C9D9804E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090612063335.GF20581@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501C9D98091@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090615015311.GC5586@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501CB84C305@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090728071537.GA18448@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501CB84C3F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090728085646.GA31294@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoPYVjdaFFiWv8/QA21oj/geyzyfAAAEiCw
Thread-topic: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time
Hi Simon,
Actually I think you have done a great work to clean up the related xend code, 
however looks we should do more. :-)

-- Dexuan

-----Original Message-----
From: Simon Horman [mailto:horms@xxxxxxxxxxxx] 
Sent: 2009?7?28? 16:57
To: Cui, Dexuan
Cc: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI 
devices at boot-time

On Tue, Jul 28, 2009 at 04:42:17PM +0800, Cui, Dexuan wrote:
> Duplicate calls to setupOneDevice() in the case of HVM  are really odd to me. 

Personally I'd rather call the code twice than have extra if logic.
But your patch is ok with me.

> BTW, actually I suspect setupOneDevice() is unnecessary for HVM guest
> since looks all of the actual work of setupOneDevice() is done by
> ioemu-dm.

I suspect you are right there.

Xen-devel mailing list