This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH][HVM] Fix a typo in vlapic.c code

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH][HVM] Fix a typo in vlapic.c code
From: "Huang2, Wei" <Wei.Huang2@xxxxxxx>
Date: Sun, 26 Jul 2009 23:36:20 -0500
Delivery-date: Sun, 26 Jul 2009 21:36:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoOc8oHw0FBsY+QRG6jpnJoSdG9Yw==
Thread-topic: [PATCH][HVM] Fix a typo in vlapic.c code

vlapic_read() takes address instead of offset as an index into APIC page. The following patch fixes a typo when calling vlapic_read() function. Not tested yet. But this typo is so obvious…




diff -r 8af26fef898c xen/arch/x86/hvm/vlapic.c

--- a/xen/arch/x86/hvm/vlapic.c Fri Jul 24 12:08:54 2009 +0100

+++ b/xen/arch/x86/hvm/vlapic.c Sun Aug 09 02:58:32 2009 -0500

@@ -605,7 +605,7 @@ static int vlapic_write(struct vcpu *v,

         gdprintk(XENLOG_INFO, "Notice: Local APIC write with len = %lx\n",len);


         alignment = offset & 0x3;

-        (void)vlapic_read(v, offset & ~0x3, 4, &tmp);

+        (void)vlapic_read(v, address & ~0x3, 4, &tmp);


         switch ( len )


Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][HVM] Fix a typo in vlapic.c code, Huang2, Wei <=