This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [patch] xend: pass-through: fix regression in the ordering o

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [patch] xend: pass-through: fix regression in the ordering of the output of xm pci list
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 21 Jul 2009 21:12:21 +1000
Delivery-date: Tue, 21 Jul 2009 04:12:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
changeset "python: Remove tab indents" (19937:e845326ae203)
introduces a minor regression in the multi-function PCI pass-through
code by causing bogus return values from the sort function
which is used to order the output of "xm pci list".

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: xen-unstable.hg/tools/python/xen/xm/main.py
--- xen-unstable.hg.orig/tools/python/xen/xm/main.py    2009-07-21 
18:51:29.000000000 +1000
+++ xen-unstable.hg/tools/python/xen/xm/main.py 2009-07-21 18:51:41.000000000 
@@ -2234,7 +2234,7 @@ def xm_pci_list(args):
             vdevfn = AUTO_PHP_SLOT
             vdevfn = x['vdevfn']
-            return (vdevfn << 32) | \
+        return (vdevfn << 32) | \
                    PCI_BDF(x['domain'], x['bus'], x['slot'], x['func'])
     devs.sort(None, f)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [patch] xend: pass-through: fix regression in the ordering of the output of xm pci list, Simon Horman <=