This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3

To: horms@xxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
From: "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Date: Tue, 21 Jul 2009 13:11:39 +0900 (JST)
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 20 Jul 2009 21:12:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090721034155.GB13928@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090717.162638.15617069.kuwa@xxxxxxxxxxxxxx> <20090721034155.GB13928@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>>>> On Tue, 21 Jul 2009 13:41:59 +1000
>>>>> horms@xxxxxxxxxxxx(Simon Horman)  said:
> On Fri, Jul 17, 2009 at 04:26:38PM +0900, KUWAMURA Shin'ya wrote:
> > This removes set() for Python 2.3, since set() is added from Python 2.4.
> set() seems to be used in a number of other places in the code.
> Is that a problem?

They cause a problem only when the corresponding feature is used.
# XenAPI, ACM, etc.

But starting xend failed by the following code:
> tools/python/xen/util/pci.py:    if len(l) != len(set(l)):

I removed it on weekly testing ad hoc.

Best regards,
  KUWAMURA Shin'ya

Xen-devel mailing list