[Xen-devel] RE: [PATCH][pvops_dom0][2/4] Introduce the external control operation interface for domain0 ACPI parser

["Yu, Ke" <ke.yu@xxxxxxxxx>]

>From: Jeremy Fitzhardinge [mailto:jeremy@xxxxxxxx]
>Sent: Tuesday, July 21, 2009 4:32 AM
>To: Yu, Ke
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Tian, Kevin
>Subject: Re: [PATCH][pvops_dom0][2/4] Introduce the external control
>operation interface for domain0 ACPI parser
>
>On 07/18/09 23:46, Yu, Ke wrote:
>> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
>> index abbe2bb..49ccb84 100644
>> --- a/drivers/acpi/processor_idle.c
>> +++ b/drivers/acpi/processor_idle.c
>> @@ -425,6 +425,12 @@ static int
>acpi_processor_get_power_info_cst(struct acpi_processor *pr)
>>
>>                 cx.power = obj->integer.value;
>>
>> +#ifdef CONFIG_PROCESSOR_EXTERNAL_CONTROL
>> +               /* cache control methods to notify external logic */
>> +               if (processor_pm_external())
>> +                       memcpy(&cx.reg, reg, sizeof(*reg));
>> +#endif /* CONFIG_PROCESSOR_EXTERNAL_CONTROL */
>>
>
>This #ifdef should be unnecessary.

This "#ifdef" is the counterpart of the following patch. The cx.reg definition 
is embraced by CONFIG_PROCESSOR_EXTERNAL_CONTROL, so the code manipulating on 
the cx.reg also need "#ifdef CONFIG_PROCESSOR_EXTERNAL_CONTROL"

> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index b09c4fd..d6bb2d2 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -77,6 +77,10 @@ struct acpi_processor_cx {
>         struct acpi_processor_cx_policy promotion;
>         struct acpi_processor_cx_policy demotion;
>         char desc[ACPI_CX_DESC_LEN];
> +#ifdef CONFIG_PROCESSOR_EXTERNAL_CONTROL
> +       /* Require raw information for external control logic */
> +       struct acpi_power_register reg;
> +#endif /* CONFIG_PROCESSOR_EXTERNAL_CONTROL */
>  };

Best Regards
Ke

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel