This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] passthru: Fix pci bar remapping for passthru dev

To: Wei Wang2 <wei.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] passthru: Fix pci bar remapping for passthru devices
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Mon, 20 Jul 2009 16:39:06 -0700
Accept-language: en-US
Acceptlanguage: en-US
Delivery-date: Mon, 20 Jul 2009 16:39:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907201603.56725.wei.wang2@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200907201603.56725.wei.wang2@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoJQv1sZXLApyMITzGVQempkHkO8QATbWmA
Thread-topic: [Xen-devel] [PATCH] passthru: Fix pci bar remapping for passthru devices
Hi Wei,

I thought the originally code already handles sizing of the BAR operations 
(writing all 1's and reading the size back). How did it work before? Did it 
work because we are relying on the a well behaved guest to restore the original 
value of the BAR after the sizing operation?

By reading the code, it is not obvious to me how does not doing r->addr = 
cfg_entry->data operation prevents calling of pt_bar_mapping_one() to create 
p2m mapping.


-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Wei Wang2
Sent: Monday, July 20, 2009 7:04 AM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] passthru: Fix pci bar remapping for passthru 

When guest code tries to get the block size of mmio, it will write all "1"s 
into pci bar register and then qemu will return all "0"s to the don't care 
bits in the emulated bar register to indicate the block size to guest code. 
In this case, we should not create p2m mapping in  pt_bar_reg_write() and
pt_exp_rom_bar_reg_write(). Attached patch fixes this issue, additional 
comment can be found in the patch.


Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
 AMD GmbH, Germany
 Operating System Research Center
 Legal Information:
 Advanced Micro Devices GmbH
 Karl-Hammerschmidt-Str. 34
 85609 Dornach b. München
 Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
 Sitz: Dornach, Gemeinde Aschheim, Landkreis München
 Registergericht München, HRB Nr. 43632

Xen-devel mailing list