This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [pvops-dom0] [patch] Hook Linux's PCI probe and remove c

To: "Han, Weidong" <weidong.han@xxxxxxxxx>
Subject: Re: [Xen-devel] [pvops-dom0] [patch] Hook Linux's PCI probe and remove callbacks
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 17 Jul 2009 16:14:18 -0700
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, 'Keir Fraser' <Keir.Fraser@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Fri, 17 Jul 2009 16:14:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <715D42877B251141A38726ABF5CABF2C0545AE597D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <715D42877B251141A38726ABF5CABF2C0545AE597D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2
On 07/15/09 22:15, Han, Weidong wrote:
> Hijack the pci_bus_type probe and remove callbacks. This option only
> requires modification to the Xen specific part of Linux.
> This is useful to add and remove pci device to Xen hypervisor when
> load and remove its driver. For example, when VFs are created by PF,
> they will be added to Xen hypervisor, and then can be assigned to guest.
> This patch is based on xen-tip-master branch of jeremy's pv-ops tree.

Yunhong Jiang sent me a version of this patch as part of his MSI work. 
This kind of interception of pci_bus_type.probe is pretty ugly, and is
unlikely to be accepted upstream in this form (the patch may only touch
a Xen file, but it is changing a variable belonging to the PCI
subsystem).  We need to work with the Linux PCI maintainers to find some
other way of achieving what we need here.

Can you explain what the functional requirements are here.  Could we
defer registering the device with Xen until some other convenient hook,
or must it be done at this point in the code?


Xen-devel mailing list