WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC] [PATCH] One watchdog trips the watchdog on allproc

To: "George Dunlap" <dunlapg@xxxxxxxxx>
Subject: Re: [Xen-devel] [RFC] [PATCH] One watchdog trips the watchdog on allprocessors
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 17 Jul 2009 14:16:12 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Jul 2009 06:16:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <de76405a0907170555t6bc89499k7d5c83dc88d80d8a@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <de76405a0907170555t6bc89499k7d5c83dc88d80d8a@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> George Dunlap <dunlapg@xxxxxxxxx> 17.07.09 14:55 >>>
>...
>+static void do_nmi_trigger_cpu(int cpu)
>+{
>+    u32 id = cpu_physical_id(cpu);
>+
>+    printk("Triggering NMI on APIC ID %x\n", id);
>+    debugtrace_dump();
>+
>+    local_irq_disable();
>+    apic_wait_icr_idle();
>+    apic_icr_write(APIC_DM_NMI | APIC_DEST_PHYSICAL, id);
>+    local_irq_enable();

You definitely don't want to enable interrupts inside an NMI. I don't think
you need to disable them either, as nothing else should have enabled
them.

>...
>+                for_each_cpu(cpu)

This is for_each_possible_cpu() now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>