This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] minios: minor buildsystem fixes

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] minios: minor buildsystem fixes
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 15 Jul 2009 11:40:22 +0100
Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 15 Jul 2009 03:41:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907151142.48343.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoFMLQpfXP13mcOTPC6nnbH0zeEVAAB/NUE
Thread-topic: [Xen-devel] [PATCH] minios: minor buildsystem fixes
User-agent: Microsoft-Entourage/
On 15/07/2009 10:42, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Attached patch changes MiniOS.mk and tools/Rules.mk
> use the OS settings we build on.
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

This may need some thought. Using XEN_OS in some places and open coding
'uname -s' in others is just not nice and is fragile.

Since stubdom is not being built in its own chroot, does it make sense for
it to override XEN_OS at all? Should we keep that as 'build host OS'? The
change around LFS in tools/Rules.mk could be indicative of a deeper issue --
information about arbitrary (non-GNU) host environments leaking into
binaries which are actually targetting GNUish minios. Can the current
approach work safely for NetBSD, Solaris, ... build hosts?

So I throw this one to Stefano/Samuel. ;-)

 -- Keir

Xen-devel mailing list