This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "keir.fraser@xxxxxxxxxxxxx" <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Mon, 6 Jul 2009 22:08:10 +0800
Accept-language: en-US
Acceptlanguage: en-US
Delivery-date: Mon, 06 Jul 2009 07:10:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907061534.31677.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501C9F46DA5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200907061534.31677.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn+PpLVHk6oK/PnTD6me13PMw0M4QAAw++w
Thread-topic: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
Thanks for comments. The revised patch is attached!

Best Regards, 
-- Dongxiao

-----Original Message-----
From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx] 
Sent: Monday, July 06, 2009 9:35 PM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: Xu, Dongxiao; keir.fraser@xxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

On Monday 06 July 2009 15:08:06 Xu, Dongxiao wrote:
> Xentop encounters error in pv-ops domain0, because the VBD path in sysfs
> changes to "/sys/devices" Also delete the macro in xenstat_netbsd.c,
> because it is not used.
> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>

Can you move the Linux specific code you add in xentop.c into xenstat_linux.c, 
please? This is an abstraction violation, otherwise.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: fix_xentop_on_pvops_dom0.patch
Description: fix_xentop_on_pvops_dom0.patch

Xen-devel mailing list