WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] x86, hvm: Allow delivery of timer interrupts to

To: Kouya Shimura <kouya@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0.
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 03 Jul 2009 07:41:46 +0100
Cc:
Delivery-date: Thu, 02 Jul 2009 23:42:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7k4otuo0g8.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn7lqFmwaESleeyQiKw7D71E0EzHwAErQlV
Thread-topic: [PATCH] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0.
User-agent: Microsoft-Entourage/12.19.0.090515
This doesn't look too bad, given the current vpt interface we have. My main
comment is regarding vpit_vcpu(), vrtc_vcpu() and vhpet.vcpu. Seems all of
these could unconditionally use i8259_target. I suggest also introducing
vhpet_vcpu(), and then pointing all three *_vcpu() macros at
pt_i8259_target() only. And get rid of the vhpet.vcpu field.

Would that work okay?

 -- Keir

On 03/07/2009 05:27, "Kouya Shimura" <kouya@xxxxxxxxxxxxxx> wrote:

> This patch is needed for kexec/kdump since kdump may halt VCPU#0.
> 
> Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel