[Xen-devel] RE: [PATCH] tools: portability fixes

["Lu, Guanqun" <guanqun.lu@xxxxxxxxx>]

>-----Original Message-----
>From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
>Sent: Thursday, July 02, 2009 6:03 PM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Cc: Lu, Guanqun
>Subject: [PATCH] tools: portability fixes
>
>
>Hi!
>
>Attached patch makes gtraceview compile on NetBSD.
>
>Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>
>@Guanqun.Lu:
>1. Why do you hardcode -lncurses, when there is a CURSES_LIBS variable ?
>    The existence of it should have ring an alarm bell that your code isn't
>    portable, i.e. that you can't blindly include <ncurses.h>.

It seems I'm still missing something when I try not to. Thanks for your finding.


>2. The string operations look dangerous in respect to security. Please fix
>them.

It uses the fixed length currently for the ease of programming at first. It 
will be fixed. Thanks for the reminder.

>
>Christoph
>
>
>--
>---to satisfy European Law for business letters:
>Advanced Micro Devices GmbH
>Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
>Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
>Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>Registergericht Muenchen, HRB Nr. 43632

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel