This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] tools: portability fixes

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] tools: portability fixes
From: "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>
Date: Fri, 3 Jul 2009 09:46:42 +0800
Accept-language: en-US
Acceptlanguage: en-US
Delivery-date: Thu, 02 Jul 2009 18:54:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907021203.04076.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200907021203.04076.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn6/FkoEpYQ01rSStCwUBJmouNZhQAgx+wA
Thread-topic: [PATCH] tools: portability fixes
>-----Original Message-----
>From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
>Sent: Thursday, July 02, 2009 6:03 PM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Cc: Lu, Guanqun
>Subject: [PATCH] tools: portability fixes
>Attached patch makes gtraceview compile on NetBSD.
>Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>1. Why do you hardcode -lncurses, when there is a CURSES_LIBS variable ?
>    The existence of it should have ring an alarm bell that your code isn't
>    portable, i.e. that you can't blindly include <ncurses.h>.

It seems I'm still missing something when I try not to. Thanks for your finding.

>2. The string operations look dangerous in respect to security. Please fix

It uses the fixed length currently for the ease of programming at first. It 
will be fixed. Thanks for the reminder.

>---to satisfy European Law for business letters:
>Advanced Micro Devices GmbH
>Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
>Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
>Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>