WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][SVM] fix spinlock panic

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: [Xen-devel] Re: [PATCH][SVM] fix spinlock panic
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 18 Jun 2009 10:47:07 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 18 Jun 2009 02:49:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200906181125.36369.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acnv+JWCzi5vboEZReyfWzjdZqxDawAASh6p
Thread-topic: [PATCH][SVM] fix spinlock panic
User-agent: Microsoft-Entourage/12.19.0.090515
On 18/06/2009 10:25, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> dangerous to reset the ASID generation back to zero); Also, as well as not
>> reallocating hsa and root_vmcb, we don't re-init them either. I don't know
>> ehether that strictly matters but obviously we could easily re-jig the code
>> to always clear_page() those pages unconditionally.
> 
> Thanks for it. Regarding ASID, I will ask back.
> Now, I trigger an ASSERT() called by setup_vmcb_dump():
> 
> (XEN) Assertion 'key_table[key].u.handler == ((void*)0)' failed at
> keyhandler.c:68

Oh good grief, I got the test at the top of start_svm() inverted. Please try
changeset 19798 which fixes this.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>