WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch][BIOS] fix trying to boot from next device

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [Patch][BIOS] fix trying to boot from next device
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Tue, 26 May 2009 22:55:36 +0900
Delivery-date: Tue, 26 May 2009 06:56:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Hi,

If boot="ndc", rombios cannot try to boot next device.
Because rombios jump to the boot vector without pushing return address,
gPXE code and so on cannot return if it fail to boot.

This patch fixes this issue.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

Best Regards,

Akio Takebe

---
diff -r 145e49b8574c tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Tue May 19 23:44:28 2009 +0100
+++ b/tools/firmware/rombios/rombios.c  Tue May 26 22:50:33 2009 +0900
@@ -8362,8 +8362,8 @@ ASM_END
   /* Jump to the boot vector */
 ASM_START
     mov  bp, sp
-//    push cs
-//    push #int18_handler
+    push cs
+    push #int18_handler
     ;; Build an iret stack frame that will take us to the boot vector.
     ;; iret pops ip, then cs, then flags, so push them in the opposite order.
     pushf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [Patch][BIOS] fix trying to boot from next device, Akio Takebe <=