WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup

To: Ryo Tsuruta <ryov@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup
From: Andrea Righi <righi.andrea@xxxxxxxxx>
Date: Mon, 4 May 2009 14:05:45 +0200
Cc: containers@xxxxxxxxxxxxxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 05 May 2009 08:42:34 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=zhxOoAqyTt5XKQ+FrByVjvUAbtrPhnw6IUoN3WsXi+Q=; b=hCtt7D8/+O6STeSJSgqUIxMu2xZGKmud2rxk0VHwgD67cdlYKI5JqXsn6jbW3hZfF5 yK8R18poiTrZYa5FX8Yo43kkUBWHelMEqmE2YX56XJw1VAhG+XOr0kkQesBBZvt3/90n 5+nQ6v84aemJ8XIP73J1KGbRBePTVimvYIGXI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=izMY8xGrfAreqFdVoYvjchsW2pnMsaHlj2fJ82sfKysxw4i7vmGZT/DG0Hs0omrdrd X3lkvvFLE0bhWjmg/zMoiR67cyXVxv9qC/9Y3pG7Cjp4n8lzAeqwMZGztve08GrEGklV kOe4bLFIYNpLsV0RYHyqZlrJwnhPK9w6viEPA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090428.214604.104034341.ryov@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090428.214423.193684619.ryov@xxxxxxxxxxxxx> <20090428.214457.226801820.ryov@xxxxxxxxxxxxx> <20090428.214535.71090234.ryov@xxxxxxxxxxxxx> <20090428.214604.104034341.ryov@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Apr 28, 2009 at 09:46:04PM +0900, Ryo Tsuruta wrote:
> The body of bio-cgroup.
> 
> Based on 2.6.30-rc3-git3
> Signed-off-by: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
> Signed-off-by: Ryo Tsuruta <ryov@xxxxxxxxxxxxx>

Hi Ryo,

few minor coding style issues reported by checkpatch.pl:

WARNING: line over 80 characters
#138: FILE: include/linux/biotrack.h:67:
+static inline void blkio_cgroup_set_owner(struct page *page, struct mm_struct 
*mm)

WARNING: line over 80 characters
#152: FILE: include/linux/biotrack.h:81:
+static inline void blkio_cgroup_copy_owner(struct page *page, struct page 
*opage)

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#513: FILE: mm/biotrack.c:265:
+EXPORT_SYMBOL(get_blkio_cgroup_id);

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#514: FILE: mm/biotrack.c:266:
+EXPORT_SYMBOL(blkio_cgroup_lookup);

total: 0 errors, 4 warnings, 515 lines checked

-Andrea

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>