[Xen-devel] linux c/s 866

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>@@ -329,11 +329,15 @@ static pte_t blktap_clear_pte(struct vm_
>        * If the address is before the start of the grant mapped region or
>        * if vm_file is NULL (meaning mmap failed and we have nothing to do)
>        */
>-      if (uvaddr < uvstart || vma->vm_file == NULL)
>+      if (vma->vm_file != NULL) {
>+              info = vma->vm_file->private_data;
>+              uvstart = info->rings_vstart + (RING_PAGES << PAGE_SHIFT);
>+      } else
>+              uvstart = uvaddr;       /* make the following if clause true */
>+      if (uvaddr < uvstart)
>               return ptep_get_and_clear_full(vma->vm_mm, uvaddr, 
>                                              ptep, is_fullmm);

It would appear to me as if the comment and the code are out of sync:
Assigning uvaddr to uvstart makes the if clause's condition false whenever
vm->vm_file == NULL. According to how the old code worked, I'd say the
code needs to be fixed, but I'm not certain, hence I'm hesitant to submit a
patch...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel