This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: Pesky '#define current' in mini-os/sched.h

To: Ferenc Wagner <wferi@xxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: Pesky '#define current' in mini-os/sched.h
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 27 Apr 2009 20:50:18 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 27 Apr 2009 12:50:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <873abt51e5.fsf@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnHcGVQ42Je9LHRSM+YsIEHoHmL2AAAP62Y
Thread-topic: [Xen-devel] Re: Pesky '#define current' in mini-os/sched.h
User-agent: Microsoft-Entourage/
On 27/04/2009 20:42, "Ferenc Wagner" <wferi@xxxxxxx> wrote:

>>> Simply removing it works in my case, but I guess there are cases when
>>> it is needed, aren't there?
>> Of course, everywhere it's used inside minios.
> Ok.  Till then, may I ask for your help to integrate ncurses into
> minios?  I'm not familiar with the build system.  Basically, I think I
> got the ncurses library built for the minios target, but can't use it
> in my c stubdom yet, it get undefined references:

The simplest fix would be to wrap the '#define current' in a '#ifdef
__MINIOS__' region. The cleaner fix would be to partition minios headers
into private vs. public and not include the former from the latter, and keep
the latter namespace-clean.

 -- Keir

Xen-devel mailing list