WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix search pathes in python code

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix search pathes in python code
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 22 Apr 2009 10:18:09 +0200
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 22 Apr 2009 01:27:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18925.60913.289411.98000@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200904211718.59770.Christoph.Egger@xxxxxxx> <18925.60913.289411.98000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Tuesday 21 April 2009 18:01:53 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] Fix search pathes in python 
code"):
> > Attached patch gets rid of hardcoded search pathes in python code.
>
> This is an interesting and useful thing to do in principle.  What it
> actually does is have the build system write the installation paths
> into the python code.  I think this is much more correct than the
> existing arrangements.
>
> I haven't however tested this specific change :-).  What platforms did
> you test it on,

NetBSD and Linux.

> and with what build process ? 

in xen toplevel source directory run

   gmake dist-tools

or

  PREFIX="/usr/local" gmake dist-tools

Then have a look into dist/install, copy the files
to your test machine machine,
set LD_LIBRARY_PATH and PYTHONPATH
and see if things work - i.e. if "xm console <domain>" finds the
xenconsole binary.

<side-note>
Once we use rpath, then setting LD_LIBRARY_PATH won't be
necessary anymore.
</side-note>

Christoph

P.S.: I'm really wondering why Linux distributors don't send such patches.
I think, they modify the xen build system to fit into their rpm's.


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>