WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] linux c/s 860

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: [Xen-devel] linux c/s 860
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 15 Apr 2009 15:59:56 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 15 Apr 2009 07:59:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Other than its comment says, this c/s doesn't only subtract 1 from r_align, but
also extends the surrounding condition to include !r_align. If r_align is zero,
ALIGN(r_align, PAGE_SIZE) will be zero too, and hence in the end r_align
will become ~0. What's the purpose of all that? Or am I missing something
here? Or is the added condition perhaps just inverted?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>