This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Explicit return type for Hypercall

To: Tej <bewith.tej@xxxxxxxxx>
Subject: Re: [Xen-devel] Explicit return type for Hypercall
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 09 Apr 2009 14:11:25 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 09 Apr 2009 06:11:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f1c9d250904090528h7ed73928nc2aaa9a455bd3faf@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acm5DrlRqtulJsB/S6GdaVVILV1/swABfYUI
Thread-topic: [Xen-devel] Explicit return type for Hypercall
User-agent: Microsoft-Entourage/
On 09/04/2009 13:28, "Tej" <bewith.tej@xxxxxxxxx> wrote:

>> The return code is ENOSYS, which is appropriate for an unimplemented
>> hypercall.
> Still it could be misleading, because in case of kernel modules
> "module-uti"l packages overrides ENOSYS with message as "Kernel does
> not have module support"
> an explicit return type could be useful here.

Separate from the kernel's return code you mean? Yes, you could certainly
define a new ioctl that returns the code in the command structure passed to
the ioctl, for example. I'd have no problem with that.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>