This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Wed, 08 Apr 2009 16:25:37 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx
Delivery-date: Wed, 08 Apr 2009 07:26:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49DCA3CF.1080905@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1239115497-1884-1-git-send-email-kraxel@xxxxxxxxxx> <1239115497-1884-3-git-send-email-kraxel@xxxxxxxxxx> <49DBAC54.7010500@xxxxxxxxxx> <49DC6CB7.8000602@xxxxxxxxxx> <49DCA3CF.1080905@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090324 Fedora/3.0-2.1.beta2.fc11 Thunderbird/3.0b2
On 04/08/09 15:17, Anthony Liguori wrote:
I meant the public stuff too. I don't like having extern variables all
over the place.

It would be better to have this in a structure that was passed to all of
the backend drivers that they then passed as a context. This will become
more useful down the road too when we start introducing a common device
model and finer grain locking.

The variables are more global xen state, not device / xenbus state. The usage is not limited to the backend drivers, the domain builder code will use them as well. There will never ever be more than one instance of these. I don't see the point of placing them into a struct and passing around a pointer.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>