WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Thomas Pfeuffer <thomas.pfeuffer@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: Fri, 3 Apr 2009 09:32:23 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Thu, 02 Apr 2009 18:33:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C5FA79C1.5885%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C5FA76E3.5880%keir.fraser@xxxxxxxxxxxxx> <C5FA79C1.5885%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmzkXHgTPa/n0P0RNGJeQlT9mWitQAAmMDUAABtYNoAGWWp4A==
Thread-topic: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Thursday, April 02, 2009 9:19 PM
>To: Keir Fraser; Thomas Pfeuffer; Yu, Ke; xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
>
>On 02/04/2009 14:06, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>
>>> I think your patch is not good in case sedf-scheduler is used. If idle VCPU
>>> is the current "running" VCPU, the scheduler timer is set to the next 
>>> "period
>>> begin" of the first VCPU in the wait queue.
>>> Your patch prevents sedf from taking the VCPUs waiting for their next period
>>> into the runnable queue again.

I did not look into the much detail of the sedf-scheduler when making this 
patch. thanks for pointing it out, Thomas.

>>
>> It¹s probably cleaner always to respect the specific scheduler¹s scheduling
>> quantum in schedule.c, but then have sched_credit.c return a very large
>> quantum (large as possible) for the idle VCPU.
>
>I checked in something to this effect as c/s 19500.
>
> -- Keir
>

This change looks good to me. Thanks.

Best Regards
Ke

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>