This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume

To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, Brendan Cully <brendan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 01 Apr 2009 11:31:46 +0100
Cc: "andy@xxxxxxxxx" <andy@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 01 Apr 2009 03:32:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1238581584.4440.18.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmytFUD2TrzTvvSTdqus1GTijZ+zQAALmMW
Thread-topic: [Xen-devel] [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
User-agent: Microsoft-Entourage/
On 01/04/2009 11:26, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

>> Could it be as simple as this? I can't remember what happens if
>> unregister_xenbus_watch is called after the xenbus connection has been
>> reset. Should we just free the guest structures without interacting
>> with xenstore at the start of the resume method?
> It may be possible to synchronise the watch handler with the
> suspend/resume/cancel cycle without removing the watch, but that starts
> to get complicated.

Could we avoid any of this logic executing if there are no net accelerators?

 -- Keir

Xen-devel mailing list