WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch] qemu-xen: pass-through: Allow slots 1e and 1f to

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Subject: [Xen-devel] Re: [patch] qemu-xen: pass-through: Allow slots 1e and 1f to be used
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 31 Mar 2009 19:55:22 +1100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 31 Mar 2009 01:55:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457511A788FB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090331073200.GA29511@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457511A788FB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Mar 31, 2009 at 03:57:33PM +0800, Cui, Dexuan wrote:
> Simon Horman wrote:
> > This fixes an oversight in my recent patch "Allow any unused PCI
> > device to be used for pass-through" whereby attempts to use slots 1e
> > and 1f for pass-through would silently fail.
> > 
> > * This affects both static and manual selection of slots
> > * This affects both hot-plug and static pass-through
> > 
> > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> > 
> > ---
> > 
> > Please consider for inclusion in 3.4
> > 
> > Index: ioemu-remote/hw/piix4acpi.c
> > ===================================================================
> > --- ioemu-remote.orig/hw/piix4acpi.c        2009-03-31 18:21:29.000000000
> > +1100 +++ ioemu-remote/hw/piix4acpi.c       2009-03-31 18:22:23.000000000
> > +1100 @@ -320,9 +320,9 @@ static void php_slots_init(void)
> >      }
> > 
> >      /* ACPI PCI hotplug controller */
> > -    register_ioport_read(ACPI_PHP_IO_ADDR, NR_PCI_DEV, 1,
> > +    register_ioport_read(ACPI_PHP_IO_ADDR, NR_PCI_DEV + 2, 1,
> >                           acpi_php_readb, &php_slots);
> > -    register_ioport_write(ACPI_PHP_IO_ADDR, NR_PCI_DEV, 1,
> > +    register_ioport_write(ACPI_PHP_IO_ADDR, NR_PCI_DEV + 2, 1,
> >                            acpi_php_writeb, &php_slots);
> >      register_savevm("pcislots", 0, 1, pcislots_save, pcislots_load,
> >                      &php_slots);
> 
> Hi Simon,
> Please send another patch to reserve the IO range in DSDT.
> You may have a look at changeset 18951 as a reference. :-)

Hi Dexuan,

Thanks for pointing that out. I will send another patch shortly.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>