WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu: unmap INTx interrupt on hot-remove

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu: unmap INTx interrupt on hot-remove
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 30 Mar 2009 16:13:17 +0100
Cc: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 30 Mar 2009 08:13:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090326051238.GD24011@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090313134807.66F0.27C06F64@xxxxxxxxxxxxxxx> <20090326051238.GD24011@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Simon Horman writes ("Re: [Xen-devel] [PATCH] ioemu: unmap INTx interrupt on 
hot-remove"):
> On Fri, Mar 13, 2009 at 01:59:24PM +0900, Yuji Shimada wrote:
> > +char mapped_machine_irq[PT_NR_IRQS] = {0};
> 
> This only initialises the first element of mapped_machine_irq[] to 0.

Statically allocated objects (that is, ones in the data and code
segments rather than on the stack) are initialised to 0 by the system
anyway.  But I agree that it's an unusual style.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel