This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xend: get rid of remains in xenstore

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xend: get rid of remains in xenstore
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Mon, 30 Mar 2009 16:55:07 +0900
Delivery-date: Mon, 30 Mar 2009 00:55:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The xenstore often holds remains of domain path.
XendDomainInfo._storeChanged thread, which is watching the
"/vm/<uuid>", might run after XendDomainInfo.cleanupDomain is done
by shutting down the domain. thus, the xenstore path
"/local/domain/<domid>" is once removed but revived again.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r e54eeff2de54 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Fri Mar 27 11:07:11 2009 +0900
+++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Mar 30 10:06:20 2009 +0900
@@ -1629,7 +1629,13 @@ class XendDomainInfo:
         if changed:
             # Update the domain section of the store, as this contains some
             # parameters derived from the VM configuration.
-            self._storeDomDetails()
+            self.refresh_shutdown_lock.acquire()
+            try:
+                # Check if the domain is shutting down
+                if self.domid != None:
+                    self._storeDomDetails()
+            finally:
+                self.refresh_shutdown_lock.release()
         return 1
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xend: get rid of remains in xenstore, Kouya Shimura <=