Re: [Xen-devel] [PATCH 3/5] Fixup dummy cpu setup.

[Simon Horman <horms@xxxxxxxxxxxx>]

On Mon, Mar 23, 2009 at 12:25:15PM +0100, Gerd Hoffmann wrote:
> Simon Horman wrote:
> >> -    env = cpu_init(NULL);
> >> +    if (cpu_model == NULL) {
> >> +#ifdef TARGET_X86_64
> >> +        cpu_model = "qemu64";
> >> +#else
> >> +        cpu_model = "qemu32";
> >> +#endif
> >> +    }
> >> +    env = cpu_init(cpu_model);
> 
> > Is there a way to achieve this without ifdef nastiness?
> 
> Well, one could try to make cpu_init(NULL) pick a sane default.  But in
> the end that most likely would just be moving the ifdef to another place.

Understood.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel